Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows access to payload in callback validator #16909

Merged
merged 1 commit into from Jan 25, 2016
Merged

Allows access to payload in callback validator #16909

merged 1 commit into from Jan 25, 2016
+28 −5

Conversation

conradkleinespel
Copy link
Contributor

@conradkleinespel conradkleinespel commented Dec 8, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #15092
License MIT
Doc PR none

xabbuh
xabbuh reviewed Dec 9, 2015
View changes
src/Symfony/Component/Validator/Tests/Constraints/CallbackValidatorTest.php
@@ -227,4 +226,28 @@ public function testAnnotationInvocationMultiValued()

$this->assertEquals(new Callback(array(__CLASS__.'_Class', 'validateCallback')), $constraint);
}

public function testPayload()
Copy link
Member

@xabbuh xabbuh Dec 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo this should be changed to something like testPayloadIsPasswordToCallback to reflect what we actually expect to happen in the test.

Copy link
Contributor

@jakzal jakzal Dec 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh you probably meant testPayloadIsPassedToCallback() ;)

Copy link
Member

@xabbuh xabbuh Dec 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you guess that? :D

Copy link
Contributor Author

@conradkleinespel conradkleinespel Dec 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the suggestion 👍

@fabpot
Copy link
Member

@fabpot fabpot commented Jan 25, 2016

Thank you @conradkleinespel.

@fabpot fabpot merged commit 26cd91d into symfony:master Jan 25, 2016
3 checks passed
fabpot added a commit that referenced this issue Jan 25, 2016
@fabpot
feature #16909 Allows access to payload in callback validator (conrad…
36c2961 
…kleinespel)

This PR was merged into the 3.1-dev branch.

Discussion
----------

Allows access to payload in callback validator

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15092
| License       | MIT
| Doc PR        | none

Commits
-------

26cd91d allows access to payload in callback validator
@conradkleinespel conradkleinespel deleted the callback-validator-payload branch Jan 25, 2016
@xabbuh xabbuh mentioned this pull request Jan 26, 2016
Closed
@fabpot fabpot mentioned this pull request May 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@conradkleinespel @fabpot @jakzal @xabbuh @carsonbot